Skip to content

Conversation

@gqcorneby
Copy link
Contributor

@gqcorneby gqcorneby commented Oct 21, 2025

📌 References

📝 Implementation

  • add UserSettings that is saved consistently in user data store (regardless of selected storage)
  • set user defaults in settings page
  • use user default inclusion modes when creating on demand

📹 Screenshots/Screen capture

2025-10-21.03-38-24.mp4

🔥 Is there anything the reviewer should know to test it?

📑 Others

  • Any change in the GUI library? If so, what branch/PR?

  • Any change in the D2 Api? If so, what branch/PR?

@gqcorneby gqcorneby requested a review from MiquelAdell October 21, 2025 04:32
@bundlemon
Copy link

bundlemon bot commented Oct 21, 2025

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
2.78MB (+1.24KB +0.04%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@gqcorneby
Copy link
Contributor Author

Workflow failures are fixed here: #1035

@MiquelAdell
Copy link
Contributor

Once the defaults are set I can not change them. I tried that in dev.est and in a play instance with a fresh install:

Screen.Recording.2025-10-21.at.08.55.39.mov

@gqcorneby
Copy link
Contributor Author

Hi @MiquelAdell! Sorry about that! Should be fixed now

Copy link
Contributor

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gqcorneby

The exclude/include dependencies configuration is in ondemand and stored sync rules.

The change has affected to ondemand sync rules, but not to stored sync rules.

If we have default settings for this configuration, I think should work in both.

To execute an ondemand sync rule and to create a new sync rule to save.

Here the video

Screen.Recording.2025-11-04.at.09.55.05.mov

@gqcorneby
Copy link
Contributor Author

Hi @xurxodev! Thanks for the feedback. I rechecked my earlier conversation with Miquel, and from what I understood, the defaults were meant to apply only to the three drop-downs in the manual (on-demand) sync modal.

Your suggestion to have them apply in the wizard as well makes sense. I’ll confirm the scope with @miquel before making any changes.

@MiquelAdell
Copy link
Contributor

Oh, I'm not sure what I defined as the scope but it would be great if the stored preferences would be applied to both places yes.
If you can @gqcorneby go ahead with it

thanks!

@gqcorneby
Copy link
Contributor Author

Hi @MiquelAdell and @xurxodev! I've applied the user defaults to the sync rule wizard.

image

@gqcorneby gqcorneby requested a review from xurxodev November 6, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants