-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/user default inclusion modes #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
Workflow failures are fixed here: #1035 |
|
Once the defaults are set I can not change them. I tried that in dev.est and in a play instance with a fresh install: Screen.Recording.2025-10-21.at.08.55.39.mov |
|
Hi @MiquelAdell! Sorry about that! Should be fixed now |
# Conflicts: # i18n/en.pot # i18n/es.po # i18n/fr.po # i18n/pt.po
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @gqcorneby
The exclude/include dependencies configuration is in ondemand and stored sync rules.
The change has affected to ondemand sync rules, but not to stored sync rules.
If we have default settings for this configuration, I think should work in both.
To execute an ondemand sync rule and to create a new sync rule to save.
Here the video
Screen.Recording.2025-11-04.at.09.55.05.mov
|
Hi @xurxodev! Thanks for the feedback. I rechecked my earlier conversation with Miquel, and from what I understood, the defaults were meant to apply only to the three drop-downs in the manual (on-demand) sync modal. Your suggestion to have them apply in the wizard as well makes sense. I’ll confirm the scope with @miquel before making any changes. |
|
Oh, I'm not sure what I defined as the scope but it would be great if the stored preferences would be applied to both places yes. thanks! |
|
Hi @MiquelAdell and @xurxodev! I've applied the user defaults to the sync rule wizard.
|

📌 References
📝 Implementation
📹 Screenshots/Screen capture
2025-10-21.03-38-24.mp4
🔥 Is there anything the reviewer should know to test it?
📑 Others
Any change in the GUI library? If so, what branch/PR?
Any change in the D2 Api? If so, what branch/PR?